Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4

Merged
merged 3 commits into from
May 4, 2020
Merged

Update dependencies #4

merged 3 commits into from
May 4, 2020

Conversation

mtomko
Copy link
Contributor

@mtomko mtomko commented May 1, 2020

This PR would subsume #3 and the work done by @Korbik

That change replaced Monad with Sync. It would also work to pass around an implicit Bracket[F, Throwable] if you want to avoid the power of Sync, although for what's going on Sync seems fine.

I'm not certain I've done the right thing with SangriaGraphQL.scala - the old IO code used IO.fromFuture but also wrapped the construction of the Future in an IO. It looks like Async.async should be safe on its own.

@tpolecat tpolecat merged commit ab8a6f6 into tpolecat:master May 4, 2020
@mtomko mtomko deleted the update-dependencies branch June 4, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants