Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would subsume #3 and the work done by @Korbik
That change replaced
Monad
withSync
. It would also work to pass around an implicitBracket[F, Throwable]
if you want to avoid the power ofSync
, although for what's going onSync
seems fine.I'm not certain I've done the right thing with
SangriaGraphQL.scala
- the old IO code usedIO.fromFuture
but also wrapped the construction of theFuture
in anIO
. It looks likeAsync.async
should be safe on its own.